Make cwd required #475
Make cwd required #475
Conversation
|
This is related to the spec change we made to make cwd required. |
|
@mrunalp maybe some of the tests need the template updated with a cwd to fix the test failures. |
start.go
Outdated
There was a problem hiding this comment.
What do you think about moving this validation to loadSpec()?
mrunalp
force-pushed
the
set_cwd
branch
2 times, most recently
from
e7b14f3 to
b18ab25
Compare
Signed-off-by: Mrunal Patel <[email protected]>
|
Updated wit the tests fixed. There is some issue on jenkins, the tests aren't even run. |
|
LGTM if janky is happy. |
There was a problem hiding this comment.
if opencontainers/runtime-spec#312 is adopted before this PR is merged, can you add a check to ensure its an abs path? filepath.IsAbs()
There was a problem hiding this comment.
Sure.
Sent from my iPhone
On Jan 15, 2016, at 6:14 AM, Doug Davis [email protected] wrote:
In spec.go:
@@ -290,6 +291,15 @@ var mountPropagationMapping = map[string]int{
"": syscall.MS_PRIVATE | syscall.MS_REC,
}+// validateSpec validates the fields in the spec
+// TODO: Add validation for other fields where applicable
+func validateSpec(spec *specs.LinuxSpec, rspec *specs.LinuxRuntimeSpec) error {
- if spec.Process.Cwd == "" {
if Make cwd an abs path to avoid ambiguity runtime-spec#312 is adopted before this PR is merged, can you add a check to ensure its an abs path? filepath.IsAbs()—
Reply to this email directly or view it on GitHub.
|
@jfrazelle ping; Something wrong with the jenkins server. |
|
LGTM |
…d_ppc_and_s390x seccomp: Add ppc and s390x to specs-go/config.go
6 participants
Signed-off-by: Mrunal Patel [email protected]